Add new_session, write_permission args #1476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
Wauplin
approved these changes
May 17, 2023
There was a problem hiding this comment.
Thanks for working on this and opening the PR @aliabid94!
Hope you don't mind but I took the opportunity to remove the legacy _is_valid_token that was used only once internally. I also added get_token_permission that I wanted to implement since quite some time now 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two kwargs to login:
new_session- if True, forces the user to login, even if a token is cached in HfFolderwrite_permission- required a write access token, raises Exception if not providedAlso
add_to_git_credentialswas not being respected fromlogintointerpreter_loginandnotebook_login, would prompt for value. Fixed